async world data IO saving #10171
Merged
async world data IO saving #10171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1d54f9f.
uses a thread per dim store, this is not ideal but generally not a huge risk, maybe we could handle this on the shared IO pool but it's generally not a big deal or likely worth the effort
electronicboy
added
the
build-pr-jar
CatTeaA
referenced
this pull request
in pufferfish-gg/Pufferfish
Jan 18, 2024
kennytv
approved these changes
Jan 18, 2024
and generally clean up the commenting a bit
lynxplay
pushed a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
Co-authored-by: Cryptite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential successor of #9408
This takes the same general sense of that PR, however makes it much safer in terms of shutdowns, unloads, etc, at the cost of having a thread per world dim store. In theory, this could easily be a shared single pool thread pool, I debated on using a shared more general pool however guaranteeing the safety of writes to this would require much more diff vs what is done here.
Download the paperclip jar for this pull request: paper-10171.zip