Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RegistryAccess for managing registries #10154

Merged
merged 6 commits into from
May 4, 2024

Conversation

Machine-Maker
Copy link
Member

Part of #8920

Required to separate the managing of API registry instances from CraftServer as CraftServer won't exist with future bootstrap-related APIs like brig commands.

@Machine-Maker Machine-Maker requested a review from a team as a code owner January 11, 2024 01:42
@Machine-Maker Machine-Maker force-pushed the feature/RegistryAccess branch 2 times, most recently from 6fcea48 to 37fc71b Compare April 21, 2024 23:06
@kashike kashike added the status: blocked Issue or Request is waiting on some other issue or change. label Apr 21, 2024
@kashike kashike self-requested a review April 21, 2024 23:44
@kashike kashike removed the status: blocked Issue or Request is waiting on some other issue or change. label Apr 21, 2024
@kashike kashike removed their request for review April 21, 2024 23:47
@Owen1212055 Owen1212055 force-pushed the feature/RegistryAccess branch 2 times, most recently from 911a8c5 to 8f58ec8 Compare April 28, 2024 20:14
@Machine-Maker Machine-Maker force-pushed the feature/RegistryAccess branch from 8f58ec8 to c00764c Compare April 29, 2024 01:15
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaperRegistryAccess needs comments explaining what's going on with storage and getting (/why), otherwise looks good

@Machine-Maker Machine-Maker force-pushed the feature/RegistryAccess branch 3 times, most recently from d3d2ff7 to 854911e Compare May 3, 2024 03:45
@Machine-Maker Machine-Maker force-pushed the feature/RegistryAccess branch from 854911e to 11ae301 Compare May 3, 2024 20:36
@Machine-Maker Machine-Maker force-pushed the feature/RegistryAccess branch from 11ae301 to 42b9aeb Compare May 3, 2024 20:49
@Machine-Maker Machine-Maker merged commit 5632210 into master May 4, 2024
5 checks passed
@Machine-Maker Machine-Maker deleted the feature/RegistryAccess branch May 4, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants