Fix untrack event not being called for all 'untracks' #10110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
fix/untrack-event
branch
from
7dbd5a8 to
c7a6557
Compare
lynxplay
force-pushed
the
fix/untrack-event
branch
from
c7a6557 to
4170e30
Compare
kennytv
approved these changes
Jan 3, 2024
Machine-Maker
force-pushed
the
fix/untrack-event
branch
from
4170e30 to
2d8ac7a
Compare
lynxplay
pushed a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10107
Moves the untrack event call back to the Entity#stopSeenByPlayer method. It was originally added there, then moved when the track event became cancellable. But the untrack event wasn't (and can't) be made cancellable so it should've been left.