Call EntityChangeBlockEvent for cake eating #10105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
reviewed
Dec 31, 2023
Owen1212055
reviewed
Dec 31, 2023
patches/server/0834-Fire-EntityChangeBlockEvent-in-more-places.patch
Outdated
Show resolved
Hide resolved
kennytv
reviewed
Jan 1, 2024
patches/server/0834-Fire-EntityChangeBlockEvent-in-more-places.patch
Outdated
Show resolved
Hide resolved
Machine-Maker
force-pushed
the
feature/more-change-block-events
branch
from
ee462e6 to
ab16f40
Compare
I think this can be left for another PR. It's not super clear if/where an event for igniting should be called as bukkit already has the BlockIgniteEvent. Perhaps a counterpart BlockExtinguishEvent instead? Either way, not clear, can be done later. |
Machine-Maker
force-pushed
the
feature/more-change-block-events
branch
2 times, most recently
from
5eda60a to
2607669
Compare
lynxplay
force-pushed
the
feature/more-change-block-events
branch
from
2607669 to
f68f5cc
Compare
lynxplay
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call EntityChangeBlockEvent for eating cakes or adding a candle to the cake