Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adventure 4.15 #10045

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Adventure 4.15 #10045

merged 1 commit into from
Dec 25, 2023

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Dec 18, 2023

Tasks

Preview Give feedback

@Machine-Maker Machine-Maker changed the title work on updating to adventure 4.15 Adventure 4.15 Dec 18, 2023
@Machine-Maker
Copy link
Member Author

So we need to decide what happens if someone registers a callback for a UUID that already has one registered, and when exactly those callbacks are fired.

@Machine-Maker Machine-Maker force-pushed the feature/adventure-4.15 branch 5 times, most recently from 051cbfe to 8a243d1 Compare December 19, 2023 19:35
@Machine-Maker Machine-Maker marked this pull request as ready for review December 19, 2023 20:07
@Machine-Maker Machine-Maker requested a review from a team as a code owner December 19, 2023 20:07
@kennytv
Copy link
Member

kennytv commented Dec 23, 2023

I dont think the others need marking, they stand fine as convenience methods for now. The callbacks should be called before bukkit events. For the same registered UUID, just override

@Machine-Maker Machine-Maker force-pushed the feature/adventure-4.15 branch 3 times, most recently from 3e7413f to 391c2f2 Compare December 23, 2023 19:30
@Machine-Maker
Copy link
Member Author

Ok, removed all the TODO comments added and left comments explaining those decisions. Should be all ready.

@kennytv kennytv merged commit 4adca3d into master Dec 25, 2023
5 checks passed
@kennytv kennytv deleted the feature/adventure-4.15 branch December 25, 2023 10:51
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants