Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more incorrect array nullability annotations #10007

Conversation

Machine-Maker
Copy link
Member

Fixes incorrect array nullability annotations. For reference for anyone not reading this, arrays require 2 annotations (1 if the element type is primitive). Like

void someMethod(@NotNull String @Nullable [] array);

means that you can pass null or an array with no null elements.

@Machine-Maker Machine-Maker requested a review from a team as a code owner December 9, 2023 07:06
@Machine-Maker Machine-Maker force-pushed the dev/1.20.3-annotation-fixes branch from 5d4c5e8 to b755d13 Compare December 9, 2023 07:14
@kennytv
Copy link
Member

kennytv commented Dec 9, 2023

Not sure I like that amount of diff over what's effectively a cosmetic change based on common assumptions, I think that should be left for later

@kennytv kennytv deleted the branch PaperMC:dev/1.20.3 December 9, 2023 17:12
@kennytv kennytv closed this Dec 9, 2023
@Machine-Maker Machine-Maker deleted the dev/1.20.3-annotation-fixes branch December 9, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants