Set true custom payload channel size limit #10006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd keep the system property in case someone wants to lower it for whatever reason |
Alright |
lynxplay
approved these changes
Dec 17, 2023
lynxplay
force-pushed
the
fix/set-true-channel-size-limit
branch
from
118497a to
439d476
Compare
Owen1212055
approved these changes
Dec 24, 2023
lynxplay
pushed a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Plugin Message packet the channel itself does not have a limit, but
Identifierhas a limit. If we look up here we can see thatIdentifiercan hold text of length32767bytes. So the max possible channel size is that32767bytes.I wonder why spigot left there so small channel size limit. Maybe it's because minecraft used to have a limit set on the channel name but now it doesn't.
EDIT: Yeah it would match: https://wiki.vg/index.php?title=Plugin_channels&diff=14556&oldid=14514
Related issue: #10003