Add proper version check to startup #10002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notTamion
force-pushed
the
improve-version-check
branch
from
ab29cef to
596f52d
Compare
notTamion
force-pushed
the
improve-version-check
branch
from
596f52d to
e55443f
Compare
notTamion
force-pushed
the
improve-version-check
branch
from
e55443f to
e7d6230
Compare
|
Given there is no inherit value in this information and administrators that want to "skip" the current "out-of-date" message can just use the property, I am closing this PR. I see the technical usage of it, but I don't think the extra web call to either downloads/github API are useful for anyone, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the shitty "version check" which basically just checks if the build is more than 21 days old.
I put the new check right after the git information is printed, which is probably where it fits the nicest without having to change anything about how the PaperVersionFetcher and the methods it calls work.
Unsure if this should be merged into the Implement PaperVersionFetcher patch