bugfix: make nat_rule_group work with panorama and ngfw #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
|
Shocking that this PR has been open since 2022 and nobody has bothered to merge or whatever with it One has to wonder if Palo is actually bothered about TF support, and if this repo is still alive? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on documentation nat_rule_group should work either with Panorama and NGFW, right now it not work as intended.
Motivation and Context
It fix nat_rule_group resource to behave what was said in documentation.
How Has This Been Tested?
I build provider, test it with Terraform code and do go tests.
Types of changes
Checklist