Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modules): Remove mode_map var in favor of static internal local value #60

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat(modules): Remove mode_map var in favor of static internal local value #60

merged 1 commit into from
Dec 21, 2023

Conversation

michalbil
Copy link
Contributor

Description

Remove mode_map input variable, create a local value to serve it's purpose.

Motivation and Context

Resolves #58

How Has This Been Tested?

Apply existing example.

Types of changes

  • Enhancement (cleaner code, no extra variable with no real usage)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

sebastianczech
sebastianczech approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalbil michalbil changed the title feat: Remove mode_map var in favor of static internal local value feat(modules): Remove mode_map var in favor of static internal local value Dec 21, 2023
pimielowski
pimielowski approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michalbil michalbil merged commit c5f7401 into main Dec 21, 2023
49 checks passed
@michalbil michalbil deleted the remove-mode-map-variable branch December 21, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimielowski pimielowski pimielowski approved these changes

@sebastianczech sebastianczech sebastianczech approved these changes

@migara migara Awaiting requested review from migara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move "mode_map" and "tag_color_map" (tags module) input variables to a local ones
3 participants
@michalbil @pimielowski @sebastianczech