Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I modified the method
check_non_finished_jobs
inCheckFirewall
class and renamed it tocheck_jobs
. Now it allows to pass some parameters (job_type
,job_status
,job_result
) to the method and now we can query any of those 3 keys values.So we can not only check whether the status is
FIN
but also if the type isCommit
or the result isOK
(or any different combination). Default parameters check only for status ofFIN
, so method's default behaviour remains the same.Motivation and Context
#161
How Has This Been Tested?
Unit tests within the repo.
Types of changes
Checklist