Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panos/base): Allow missing tfin attribute in Commit-All result from a device #582

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

pavelrn
Copy link
Contributor

@pavelrn pavelrn commented Nov 18, 2024

Description

Issue described in #581.

Motivation and Context

Closes #581.

How Has This Been Tested?

  1. poetry run make test

  2. Integration tests incl. Commit and Commit-All performed in the lab.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shinmog shinmog merged commit 0f1c0a5 into PaloAltoNetworks:develop Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving KeyError: 'tfin' when _parse_job_results
2 participants