Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panos/base): Added check for commit_response text validation #557

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(panos/base): Added check for commit_response text validation #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion panos/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4900,7 +4900,7 @@ def _commit(
except AttributeError:
if exception:
raise err.PanCommitNotNeeded("Commit not needed", pan_device=self)
else:
elif commit_response.find("./msg/line") is not None:
# By getting here, there was no "./result/job" in the commit response,
# and there was no exception raised either, so capture the response message
commit_response_msg = commit_response.find("./msg/line").text
Expand All @@ -4921,6 +4921,7 @@ def _commit(
"messages": [commit_response_msg],
}
return log_collector_group_push_result
else:
return
if not sync:
# Don't synchronize, just return
Expand Down
Loading