Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Organisation Setting missing option #838

Merged
merged 3 commits into from
May 25, 2021
Merged

[Fix] Organisation Setting missing option #838

merged 3 commits into from
May 25, 2021

Conversation

anand-aman
Copy link
Contributor

@anand-aman anand-aman commented May 23, 2021 •
edited
Loading

What kind of change does this PR introduce?

Did you add tests for your changes?
No. Tested the app manually.

If relevant, did you update the documentation?
Not required.

Summary

  • 'Organisation Setting' option for the organisation creator was missing instead 'Leave This Organisation' was displayed.
  • This PR fixes Issue [Bug] Organization Setting not showing up #833
  • A boolean variable "isCreator" in the "profile_page.dart" was created to check if the user is the creator or not, that variable was never initialized so it was null and was the root cause for the bug.
  • Code reformating for "profile_page_viewModel.dart" and "profile_page.dart" has also been done which makes it more readable.

Does this PR introduce a breaking change?
No

Other Information

Screenshot with Organisation Setting option

@anand-aman
Organisation setting bug fix
22e5a55 
- Fixes bug PalisadoesFoundation#833
- Code reformatting of profile_page_viewModel.dart and profile_page.dart
@anand-aman
Copy link
Contributor Author

@palisadoes This PR is ready for review.

Thanks
Aman Anand

TheHazeEffect
TheHazeEffect requested changes May 24, 2021
View reviewed changes
Copy link
Contributor

@TheHazeEffect TheHazeEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall everything seems fine nice job, just these two changes and I should be able to complete the review and merge into master

anand-aman added 2 commits May 24, 2021 20:33
@anand-aman
Simplification of LeaveOrg and OrgSetting Button
69378aa
@anand-aman
Using snake case in file names
eb3f815 
- Flutter SDK was showing Warning as the Camel case was used in the file names so the file was renamed as snake case.
TheHazeEffect
TheHazeEffect approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@TheHazeEffect TheHazeEffect left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR resolves Issue #838

Ready to be merged

Nice Job @anand-aman

@TheHazeEffect TheHazeEffect merged commit d0a2473 into PalisadoesFoundation:master May 25, 2021
@anand-aman anand-aman mentioned this pull request May 25, 2021
Closed
Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this pull request Mar 29, 2023
@nishant3721
Test for resolvers/GroupChat/index.ts (PalisadoesFoundation#838)
ec4c54c 
* upgraded the version of jsonwebtoken to @9.0.0

* Test for resolvers/GroupChat/index.ts

Co-authored-by: Nishant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheHazeEffect TheHazeEffect TheHazeEffect approved these changes

@dellyjm dellyjm Awaiting requested review from dellyjm

Assignees

@anand-aman anand-aman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Organization Setting not showing up
2 participants
@anand-aman @TheHazeEffect