Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr #2139

Closed
wants to merge 6 commits into from
Closed

Test pr #2139

wants to merge 6 commits into from

Conversation

Azad99-9
Copy link
Contributor

@Azad99-9 Azad99-9 commented Nov 25, 2023

What kind of change does this PR introduce?

This PR adds tests to the router.dart page.

Issue Number:

Fixes #1473

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Motive is to make the code coverage of the router.dart file to 100%

Does this PR introduce a breaking change?

No

Other information

Created a new file: test/router_test.dart

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@Azad99-9
Copy link
Contributor Author

@palisadoes this is the test pr that you have suggested me to raise, the test is failing here too.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9dc3483) 78.99% compared to head (129e797) 79.88%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2139      +/-   ##
===========================================
+ Coverage    78.99%   79.88%   +0.88%     
===========================================
  Files          152      152              
  Lines         7456     7456              
===========================================
+ Hits          5890     5956      +66     
+ Misses        1566     1500      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Azad99-9 Azad99-9 mentioned this pull request Nov 25, 2023
@palisadoes
Copy link
Contributor

It's starting to fail in other repos. The GitHub action hasn't been updated since September. A dependency has changed and the authors will need to fix it. We'll have to ignore it for now.

@palisadoes
Copy link
Contributor

Closing

@palisadoes palisadoes closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unittest for router.dart
2 participants