-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test pr #2139
Test pr #2139
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
@palisadoes this is the test pr that you have suggested me to raise, the test is failing here too. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2139 +/- ##
===========================================
+ Coverage 78.99% 79.88% +0.88%
===========================================
Files 152 152
Lines 7456 7456
===========================================
+ Hits 5890 5956 +66
+ Misses 1566 1500 -66 ☔ View full report in Codecov by Sentry. |
It's starting to fail in other repos. The GitHub action hasn't been updated since September. A dependency has changed and the authors will need to fix it. We'll have to ignore it for now. |
Closing |
What kind of change does this PR introduce?
This PR adds tests to the router.dart page.
Issue Number:
Fixes #1473
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Motive is to make the code coverage of the router.dart file to 100%
Does this PR introduce a breaking change?
No
Other information
Created a new file: test/router_test.dart
Have you read the contributing guide?
Yes