-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch plugin list test #2115
fetch plugin list test #2115
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2115 +/- ##
===========================================
+ Coverage 76.97% 77.29% +0.32%
===========================================
Files 152 152
Lines 7456 7456
===========================================
+ Hits 5739 5763 +24
+ Misses 1717 1693 -24 ☔ View full report in Codecov by Sentry. |
@aashimawadhwa will be handling all issue queries and seeking reviewers for PRs. When necessary, this contributor will contact other contributors who will be able to assist. Please ask them for guidance on your future questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* fetch plugin list test * test helpers * fixing workflow * fixing workflow * fixing failing test * fixing failing tets
What kind of change does this PR introduce?
Test for fetch_plugin_list.dart
Issue Number:
Fixes #1988
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes