-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cross browser compatibility #932
Feature/cross browser compatibility #932
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests and there are no merge conflicts. The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@Abhi-MS If you could attach a video from the inspector or add some text above the uploaded images, it would be helpful to understand how the UI looks at different widths |
Hi, Thank you for the feedback. I will add a screen recording. Please note that this PR is related to the following comments on the issue: #916. Hope this gives some context while I prepare a screen recording. Comments: |
Hi, the PR should now have the videos and description just as you asked. |
@rishav-jha-mech PTAL and merge if it looks OK |
What kind of change does this PR introduce?
Standardisation on a width and justification
Issue Number:
Fixes #916
Did you add tests for your changes?
Snapshots/Videos:
Screen recordings showing responsiveness on various screen sizes,
Screen.Recording.2025-01-08.235205.mp4
Screen.Recording.2025-01-08.235319.mp4
Screen.Recording.2025-01-08.235413.mp4
Screen.Recording.2025-01-08.235558.mp4
If relevant, did you update the documentation?
Not relevant
Summary
Updated the card rows to have standard width and justification. 1280 px was set for the width of card rows for very wide screens.
Does this PR introduce a breaking change?
No
Other information
Updated other CSS for responsiveness
Have you read the contributing guide?
Yes