fix: Funds & Campaign Pages Violate The Figma Style #3478
Conversation
WalkthroughThis pull request involves updates to documentation and styling across several files. The changes include updating the documentation for the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/screens/OrganizationFunds/OrganizationFunds.tsx (2)
23-38: LGTM! Consider documenting CSS variables.Good job replacing hardcoded values with CSS variables for better maintainability and design consistency. Consider adding a comment documenting the expected values of these CSS variables for future reference.
Add a comment like this above the
dataGridStyleobject:+/** + * CSS Variables used: + * --table-head-radius: Border radius for the table header + * --row-background: Background color for table rows + */ const dataGridStyle = {
105-107: Consider using useEffect for document title.While setting the document title is good for accessibility, it's better to handle it using React's
useEffecthook for consistency with React's lifecycle.const { t: tCommon } = useTranslation('common'); - // Set the document title based on the translation - document.title = t('title'); + useEffect(() => { + document.title = t('title'); + }, [t]); const { orgId } = useParams();
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/docs/auto-docs/screens/OrganizationFunds/OrganizationFunds/functions/default.md(1 hunks)src/screens/OrganizationFundCampaign/CampaignModal.tsx(1 hunks)src/screens/OrganizationFunds/OrganizationFunds.tsx(3 hunks)src/style/app.module.css(3 hunks)
✅ Files skipped from review due to trivial changes (2)
- src/screens/OrganizationFundCampaign/CampaignModal.tsx
- docs/docs/auto-docs/screens/OrganizationFunds/OrganizationFunds/functions/default.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test Application
🔇 Additional comments (2)
src/screens/OrganizationFunds/OrganizationFunds.tsx (1)
337-337: LGTM! Consistent styling applied.Good use of modular CSS class for the dropdown styling, maintaining consistency with the project's CSS architecture.
src/style/app.module.css (1)
570-570: LGTM! Improved color variable consistency.The border property now uses the standardized
--dropdown-bordervariable instead of the specific--dropdown-border-color, which better aligns with the design system's color variables.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3478 +/- ##
=====================================================
+ Coverage 1.90% 88.80% +86.89%
=====================================================
Files 316 338 +22
Lines 8249 8627 +378
Branches 1880 1922 +42
=====================================================
+ Hits 157 7661 +7504
+ Misses 8083 636 -7447
- Partials 9 330 +321 ☔ View full report in Codecov by Sentry. |
|
Hi @palisadoes, |
Yes that's OK |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/screens/OrganizationFundCampaign/OrganizationFundCampagins.tsx (2)
190-190: Enhance accessibility of the '#' column header.While '#' is a common convention, screen readers might not properly announce it. Consider adding an
aria-labelto provide a more descriptive label for screen readers.{ field: 'id', - headerName: '#', + headerName: '#', + renderHeader: () => ( + <div aria-label="Serial Number">#</div> + ), flex: 1, minWidth: 100,
Line range hint
190-199: Enhance type safety for GridCellParams.Consider adding specific type parameters to
GridCellParamsto better type the row data structure.-renderCell: (params: GridCellParams) => { +renderCell: (params: GridCellParams<any, { id: number; campaign: InterfaceCampaignInfo }>) => {
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/screens/OrganizationFundCampaign/OrganizationFundCampagins.tsx(3 hunks)src/screens/OrganizationFunds/OrganizationFunds.tsx(5 hunks)src/style/app.module.css(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/screens/OrganizationFunds/OrganizationFunds.tsx
- src/style/app.module.css
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test Application
🔇 Additional comments (1)
src/screens/OrganizationFundCampaign/OrganizationFundCampagins.tsx (1)
212-212: LGTM! Verify hyperlink color implementation.The change to use
styles.hyperlinkTextaligns with the team's decision to standardize hyperlink colors to #1778F2.Run this script to verify the hyperlink color implementation:
✅ Verification successful
Verified: Hyperlink color matches team standard
The
hyperlinkTextclass correctly implements the agreed-upon #1778F2 color through the CSS variable--hyperlink-text-color.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the hyperlinkText class uses the agreed color #1778F2 # Search for hyperlinkText class definition and its color rg -l "hyperlinkText" --type css rg "hyperlinkText.*color.*1778F2" --type cssLength of output: 104
Script:
#!/bin/bash # Check the actual implementation of hyperlinkText class rg "hyperlinkText" -A 5 -B 5 src/style/app.module.cssLength of output: 368
Script:
#!/bin/bash # Find the definition of --hyperlink-text-color variable rg "--hyperlink-text-color" --type cssLength of output: 463
Script:
#!/bin/bash # Search for hyperlink color variable definition, escaping the double dash rg "\-\-hyperlink-text-color" --type cssLength of output: 165
Fundraising.Campaigns.Fix.movI've fixed the requested issues. Please take a look |
palisadoes
merged commit 891ac62
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
This PR updates the styling of the Funds & Campaign Pages to align with the Figma design specifications.
Issue Number:
Fixes #3175
Snapshots/Videos:
OrganizationFunds.mp4
If relevant, did you update the documentation?
Summary
This PR resolves issues related to the design mismatch and ensures the page adheres to the figma design guidelines.
Does this PR introduce a breaking change?
No
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Release Notes
Documentation
OrganizationFundscomponent.Style
CampaignModalclose button.OrganizationFundscomponent styling with CSS variables.DataGridcomponent, including updated hover effects and border properties.User Experience
OrganizationFundspage.DataGrid.