-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored src/screens/UserPortal/Campaigns/PledgeModal.test.tsx from jest to vitest #3350
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 218 files out of 300 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3350 +/- ##
=====================================================
+ Coverage 8.40% 89.81% +81.41%
=====================================================
Files 312 334 +22
Lines 8105 8595 +490
Branches 1803 1899 +96
=====================================================
+ Hits 681 7720 +7039
+ Misses 7347 614 -6733
- Partials 77 261 +184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@syedali237 attach the screenshot of running test cases of this file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why there is so many file changes ?
@noman2002 These are auto-docs, getting generated from husky pre-commit. This is how it's supposed to be. |
@gautam-divyanshu That's fine. But what about the changing links with usernames and this approach seems a bit vague. Meanwhile can you push a commit to only run husky commit for changes files in PR |
@varshith257 Only these links get updated; if we delete these in the post-generate-docs script, then this is supposed to be fine. |
I am fixing it, |
@palisadoes @varshith257 fixed in this pr, #3351 |
@syedali237 I have merged the PR. Pull upstream and check |
@varshith257 @gautam-divyanshu while merging the latest upstream, there are more than 700+ merge conflicts should i simply raise a new PR. |
Yes go with it |
Closing.. |
What kind of change does this PR introduce?
Refactoring
Issue Number:
Fixes #3347
Snapshots/Videos:
N/A
If relevant, did you update the documentation?
No
Summary
Migrated src/screens/UserPortal/Campaigns/PledgeModal.test.tsx from jest to vitest.
Does this PR introduce a breaking change?
No
Checklist
CodeRabbit AI Review
Test Coverage
Other information
the commit includes unnecessary file changes.
Have you read the contributing guide?
Yes