Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code coverage of people.tsx #3308

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed a comment
Dhiren-Mhatre committed Jan 18, 2025
commit 382ab230ae1d047f414274f81d91ccaecd541fd9
1 change: 0 additions & 1 deletion src/screens/UserPortal/People/People.tsx
Original file line number Diff line number Diff line change
@@ -113,20 +113,19 @@

useEffect(() => {
if (data2?.organizations?.[0]?.admins) {
const adminsList = data2.organizations[0].admins.map(
(admin: InterfaceMember) => ({

Check warning on line 117 in src/screens/UserPortal/People/People.tsx

Codecov / codecov/patch

src/screens/UserPortal/People/People.tsx#L116-L117

Added lines #L116 - L117 were not covered by tests
...admin,
userType: 'Admin',
}),
);
setAdmins(adminsList);

Check warning on line 122 in src/screens/UserPortal/People/People.tsx

Codecov / codecov/patch

src/screens/UserPortal/People/People.tsx#L122

Added line #L122 was not covered by tests
}
}, [data2]);

// Updated members effect
useEffect(() => {
if (data?.organizationsMemberConnection?.edges) {
const membersList = data.organizationsMemberConnection.edges.map(

Check warning on line 128 in src/screens/UserPortal/People/People.tsx

Codecov / codecov/patch

src/screens/UserPortal/People/People.tsx#L128

Added line #L128 was not covered by tests
(memberData: InterfaceMember) => ({
...memberData,
userType: admins?.some((admin) => admin._id === memberData._id)
@@ -134,7 +133,7 @@
: 'Member',
}),
);
setAllMembers(membersList);

Check warning on line 136 in src/screens/UserPortal/People/People.tsx

Codecov / codecov/patch

src/screens/UserPortal/People/People.tsx#L136

Added line #L136 was not covered by tests
setMembers(mode === 0 ? membersList : admins);
}
}, [data, admins, mode]);