-
-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma: People Page Violates The Figma Style Guide #3171 #3274
Changes from all commits
997e7cb
c873b7f
4ba5d8a
59dfb45
c28c3d8
a377c16
e0f3c6c
3a4eb6b
7959fbb
c597c38
73d0d71
5ad1953
762b6a4
ba82b69
d7ad796
e5c8b87
ef42c3a
2e2828b
0a7f31e
929ea91
5ce3410
ef2fa18
6295d17
a077c6c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -195,14 +195,16 @@ jobs: | |||||||||||||||
id: changed-files | ||||||||||||||||
uses: tj-actions/changed-files@v45 | ||||||||||||||||
|
||||||||||||||||
- name: Set up Python | ||||||||||||||||
uses: actions/setup-python@v5 | ||||||||||||||||
with: | ||||||||||||||||
python-version: 3.9 | ||||||||||||||||
- name: Filter TypeScript files | ||||||||||||||||
id: filter-files | ||||||||||||||||
run: | | ||||||||||||||||
echo "ts_files=$(echo '${{ steps.changed-files.outputs.all_changed_files }}' | tr ',' '\n' | grep -E '\.(ts|tsx)$' | tr '\n' ' ')" >> $GITHUB_OUTPUT | ||||||||||||||||
shell: bash | ||||||||||||||||
|
||||||||||||||||
- name: Run Python script | ||||||||||||||||
if: steps.filter-files.outputs.ts_files != '' | ||||||||||||||||
run: | | ||||||||||||||||
python .github/workflows/scripts/eslint_disable_check.py --files ${{ steps.changed-files.outputs.all_changed_files }} | ||||||||||||||||
python .github/workflows/scripts/eslint_disable_check.py --files ${{ steps.filter-files.outputs.ts_files }} | ||||||||||||||||
Comment on lines
+205
to
+207
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Improve conditional execution formatting. The indentation of the - if: steps.filter-files.outputs.ts_files != ''
+ if: ${{ steps.filter-files.outputs.ts_files != '' }}
run: |
python .github/workflows/scripts/eslint_disable_check.py --files ${{ steps.filter-files.outputs.ts_files }} 📝 Committable suggestion
Suggested change
|
||||||||||||||||
|
||||||||||||||||
Check-Code-Coverage-Disable: | ||||||||||||||||
name: Check for code coverage disable | ||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
npm run format:fix | ||
# npm run lint:fix | ||
npm run lint-staged | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
1 2 3 4 5 | ||
6 7 8 9 10 | ||
11 12 13 14 15 | ||
16 17 18 19 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix YAML syntax error and improve file filtering.
There's a syntax error in the YAML structure. Additionally, the file filtering could be more robust.
Apply this diff to fix the syntax and improve the filtering:
📝 Committable suggestion
🧰 Tools
🪛 yamllint (1.35.1)
[error] 198-198: syntax error: expected , but found ''
(syntax)