Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/admin docs gen #3259

Conversation

Rukhsarkh
Copy link

What kind of change does this PR introduce?
This PR solves the second part of #2970 - Ensure the autogenerated markdown based on the code base's comments is added to the site in an intuitive way.

Issue Number:
Fixes #2970

Did you add tests for your changes?
No

If relevant, did you update the documentation?
NOT manually, Docs will be auto-generate by husky hooks

Summary
Documentation is structured into two parts- autogenerated documentation which is done by husky/pre-commit hook (npm auto generate-docs) and docs/auto-docs directory and manual documentation which is done by removing default docusaurus files and making 2 placeholders (user-guide and developer guide). This documentation section is accessible through general navbar item.

Does this PR introduce a breaking change?
No

Other information
Creation of new file tsconfig.docs.json was done to optimize TypeScript Compilation for Documentation. It configures TypeScript to handle files in a way that aligns with the documentation generation process. tsconfig.json might have stricter rules (e.g., strict: true), which aren't necessary for docs and were hindering doc gen unnecessarily.

Have you read the contributing guide?
Yes

@Rukhsarkh Rukhsarkh requested a review from palisadoes as a code owner January 12, 2025 06:11
Copy link
Contributor

coderabbitai bot commented Jan 12, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

218 files out of 300 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.82%. Comparing base (33e7cd1) to head (6ab4bda).
Report is 10 commits behind head on develop-postgres.

Files with missing lines Patch % Lines
src/components/CheckIn/TableRow.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           develop-postgres    #3259       +/-   ##
=====================================================
+ Coverage              8.53%   89.82%   +81.29%     
=====================================================
  Files                   309      331       +22     
  Lines                  7976     8583      +607     
  Branches               1766     1901      +135     
=====================================================
+ Hits                    681     7710     +7029     
+ Misses                 7218      612     -6606     
- Partials                 77      261      +184     
Flag Coverage Δ
combined 89.82% <0.00%> (?)
jest 8.42% <0.00%> (?)
vitest 89.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

@bint-Eve @tasneemkoushar

  1. Did you see this? It shows how to do commits to an existing PR
    1. https://github.com/actions/checkout#push-a-commit-using-the-built-in-token
    2. It says that the user should be:
      1. {user.id}+{user.login}@users.noreply.github.com
  2. The advantage is that the commit is completely under the control of GitHub and not a contributor who may make a mistake
  3. I was going through the closed PRs and didn't see this approach

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on doing the merge in the PR not the Push GitHub Workflow.

gkbishnoi07 and others added 4 commits January 15, 2025 11:39
* implement a Visit button in the Joined Organizations filter

* Resolved: Potential Issue Identified by CodeRabbit AI

* Resolved: Potential Issue Identified by CodeRabbit AI

* Resolved: Potential Issue Identified by CodeRabbit AI

* Resolved: Potential Issue Identified by CodeRabbit AI

* Update src/components/OrganizationCard/OrganizationCard.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Added test cases

* Added test cases

* added tsdoc

* resolve: all issue

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…3277)

* Update Contributing.md

* Fixed formatting

* Fix linting error

* updated eslintignore to exclude markdown files

* Implemented requested changes

* Removed numbering
* changed green to blue

* updated funds section

* people section css updated

* updated Tags section

* venues, action items, advertisments, plugins sections updated

* fixed code coverage test

* fixed code coverage test

* CSS methodology added

* fixed linting

---------

Co-authored-by: Rahul Chougule <[email protected]>
@tasneemkoushar
Copy link
Contributor

@bint-Eve there are couple of changes in the src folder. If this is some other issue, can you extract those changes to a separate PR please.

palisadoes and others added 4 commits January 16, 2025 16:20
* Fixed error message on PostCard.tsx

* Added translation of text and added a test case for my code

* handle empty comment validation

* updated error handling

* improved error handling

* Improve error handling and add test coverage for edge cases

* Added missing providers
Rukhsarkh and others added 3 commits January 18, 2025 20:34
* Improved Code Coverage of UserListCard.tsx

* Updated Code Rabbit suggestions and fixed the failing test case

* Fixed Few CodeRabbit Suggestions
* chore: fixed node warning and deprecation msgs

* trigger ci: rerun pipeline
@palisadoes palisadoes added the ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files label Jan 18, 2025
@palisadoes
Copy link
Contributor

Please fix the conflicting file

@palisadoes
Copy link
Contributor

Merge with the latest upstream and reinstall packages

@tasneemkoushar
Copy link
Contributor

@bint-Eve we want to merge your PR, can you please resolve conflicts.

@tasneemkoushar
Copy link
Contributor

@bint-Eve you need to give write permission to the workflow as well, only then it is suppose to do the commit to the branch.
take reference from this pr

@palisadoes
Copy link
Contributor

@gautam-divyanshu tried that without success. He feels the reason why that PR passed was that there was nothing to commit.

syedali237 and others added 19 commits January 18, 2025 12:44
* added test cases in src/screens/Users/Users.spec.tsx

* fixed linting issues

* fixed linting issues

* fixed linting issues

* added test case to improve coverage in the Organization.mocks.ts file

* improved coverage in Users.tsx
* improve code coverage of people.tsx

* fixed formating

* added coderabit suggetions

* removed a comment

* removed redundant comment

* added code rabbit's suggetions

* added code rabbit's suggetions
* auto-docs

* yarn to npm

* broken links fixed and code refactored

* github action created

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* docs removed

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* github action removed & husky used

* auto docs in gitignore

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated

* pull-request.yml updated
* Code coverage improvement

* Linting issue resolved

* Reduced the no of ignore comments by adding more tests

* Reduce no of lines in OrganizationTagsMocks.ts

* Deleted MOCKS_EMPTY_USER_TAG

* Added appropiate error message

* Resolving conflicting files

* Removed all ignore statements
* Updated documentation layout

* Removed outdated sidebar
* Updated documentation layout

* Removed outdated sidebar

* Minor change to test website deployment
* Revert "push-deploy-website.yml updated (#3364)"

This reverts commit ca806cc.

* Update push-deploy-website.yml
* ui fix

* fix

* css fix

* Update src/screens/UserPortal/People/People.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix

* fix

* Update src/style/app.module.css

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* add test and ui fix

* fix

* ui fix

* fix

* ui fix

* ui fix

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@Rukhsarkh
Copy link
Author

closing this PR as this task is done in another PR

@Rukhsarkh Rukhsarkh closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files
Projects
None yet
Development

Successfully merging this pull request may close these issues.