This repository was archived by the owner on Nov 23, 2021. It is now read-only.
Management Portal #372
Closed
Management Portal #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palisadoes
reviewed
Oct 31, 2020
| # Block access if no user was found in session | ||
| return response | ||
|
|
||
| response = {'data':{'message': 'Query did not run'}} |
There was a problem hiding this comment.
Initialize response at beginning
palisadoes
reviewed
Oct 31, 2020
| # number of days | ||
| oldestDay = (datetime.datetime.fromtimestamp((_difference / 1000))).day | ||
|
|
||
| response = {'data':{'oldestDay': oldestDay, 'message': 'Query ran'}} |
There was a problem hiding this comment.
Add code number to response. Possibly as a separate field.
palisadoes
reviewed
Oct 31, 2020
|
|
||
| # Define the AGENTS global variable | ||
| USERS = Blueprint('USERS', __name__) | ||
|
|
palisadoes
reviewed
Oct 31, 2020
| # Define the AGENTS global variable | ||
| AGENTS = Blueprint('AGENTS', __name__) | ||
|
|
||
| @AGENTS.route('/api/agent', methods=['GET']) |
palisadoes
reviewed
Oct 31, 2020
|
|
||
| # Define the AGENTS global variable | ||
| DATAPOINTS = Blueprint('DATAPOINTS', __name__) | ||
|
|
palisadoes
suggested changes
Oct 31, 2020
There was a problem hiding this comment.
- Documentation needs to be improved greatly.
- It would be good for your Flask API results to return a status code along with the message. Or no message at all. For example a blank dict if nothing found, or a 404 if invalid.
- There are number of cases where variables should be initialized earlier.
Generally much better than the previous PR. Congrats.
|
|
||
| # Define the PANEL global variable | ||
| PANEL = Blueprint('PANEL', __name__) | ||
|
|
setup/_pattoo/db.py
Outdated
| password, | ||
| role)) | ||
| print( | ||
| '\n\nUsername: {}\nPassword: {}\nRole: {} ' |
There was a problem hiding this comment.
Use triple quoting and you won't need to insert the \n values.
'''\
Username: {}
Password: {}
Role: {}
'''.format(username, password, role)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests and documentation are on their way.
So far:
Pending: