Overlay: Remove unecessary buttons #149
Annotations
13 errors and 34 warnings
Codespell
Process completed with exit code 1.
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax)
Process completed with exit code 1.
|
Cpplint
Process completed with exit code 1.
|
Clang-tidy:
src/Gui/MainWindow.cpp#L2437
'moc_MainWindow.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/OverlayManager.cpp#L2091
'moc_OverlayManager.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/OverlayWidgets.cpp#L2741
'moc_OverlayWidgets.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/PreferencePages/DlgSettingsUI.cpp#L32
'ui_DlgSettingsUI.h' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/TaskView/TaskView.cpp#L892
'moc_TaskView.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/TextDocumentEditorView.cpp#L220
'moc_TextDocumentEditorView.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/ToolBarManager.cpp#L1389
'moc_ToolBarManager.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/Tree.cpp#L5853
'moc_Tree.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy:
src/Gui/WorkbenchSelector.cpp#L436
'moc_WorkbenchSelector.cpp' file not found [clang-diagnostic-error]
|
Clang-tidy
Process completed with exit code 1.
|
Codespell:
src/Gui/Stylesheets/FreeCAD Dark.qss#L2534
misalignement ==> misalignment
|
Codespell:
src/Gui/Stylesheets/FreeCAD Light.qss#L2517
misalignement ==> misalignment
|
Codespell:
src/Gui/WorkbenchSelector.cpp#L115
overwriten ==> overwritten
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Gui/Tree.cpp#L1104
objitem->object()->setupContextMenu(&editMenu, this, SLOT(onStartEditing()));
|
Cpplint:
src/Gui/CommandWindow.cpp#L44
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Cpplint:
src/Gui/CommandWindow.cpp#L266
Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
|
Cpplint:
src/Gui/CommandWindow.cpp#L431
Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
|
Cpplint:
src/Gui/CommandWindow.cpp#L210
Add #include <string> for string [build/include_what_you_use] [4]
|
Cpplint:
src/Gui/CustomTitleBar.cpp#L38
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Cpplint:
src/Gui/CustomTitleBar.cpp#L39
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Cpplint:
src/Gui/CustomTitleBar.h#L25
#ifndef header guard has wrong style, please use: SRC_GUI_CUSTOMTITLEBAR_H_ [build/header_guard] [5]
|
Cpplint:
src/Gui/CustomTitleBar.h#L67
#endif line should be "#endif // SRC_GUI_CUSTOMTITLEBAR_H_" [build/header_guard] [5]
|
Cpplint:
src/Gui/FramelessWindow.cpp#L50
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Cpplint:
src/Gui/FramelessWindow.cpp#L51
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Clazy:
src/Gui/FramelessWindow.h#L2
'/*' within block comment [-Wcomment]
|
Clazy:
src/Base/Type.h#L119
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L150
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L155
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L160
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L165
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L170
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L175
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L266
all parameters should be named in a function [readability-named-parameter]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L301
variable 'pcAction' is not initialized [cppcoreguidelines-init-variables]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L337
variable 'pcAction' is not initialized [cppcoreguidelines-init-variables]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L431
single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L431
'action' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L434
member variable 'action' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L437
implicit conversion 'MainWindow *' -> 'bool' [readability-implicit-bool-conversion]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L437
implicit conversion 'QStatusBar *' -> 'bool' [readability-implicit-bool-conversion]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L519
variable 'pcAction' is not initialized [cppcoreguidelines-init-variables]
|
Clang-tidy:
src/Gui/CommandWindow.cpp#L521
10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Loading