Update src/Main/MainGui.cpp #131
Annotations
1 error and 24 warnings
Cpplint
Process completed with exit code 1.
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Cpplint:
src/Main/MainGui.cpp#L74
Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
|
Cpplint:
src/Main/MainGui.cpp#L322
Add #include <iostream> for cerr [build/include_what_you_use] [4]
|
Cpplint:
src/Main/MainGui.cpp#L438
Add #include <string> for string [build/include_what_you_use] [4]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3131
Pass small and trivially-copyable type by value (const unsigned long &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3134
Pass small and trivially-copyable type by value (const std::nullptr_t &) [-Wclazy-function-args-by-value]
|
Clang-tidy:
src/Main/MainGui.cpp#L63
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
|
Clang-tidy:
src/Main/MainGui.cpp#L71
class 'Redirection' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
Clang-tidy:
src/Main/MainGui.cpp#L74
single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor]
|
Clang-tidy:
src/Main/MainGui.cpp#L84
do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
|
Clang-tidy:
src/Main/MainGui.cpp#L98
an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape]
|
Clang-tidy:
src/Main/MainGui.cpp#L101
function is not thread safe [concurrency-mt-unsafe]
|
Clang-tidy:
src/Main/MainGui.cpp#L102
function is not thread safe [concurrency-mt-unsafe]
|
Clang-tidy:
src/Main/MainGui.cpp#L110
function is not thread safe [concurrency-mt-unsafe]
|
Clang-tidy:
src/Main/MainGui.cpp#L111
function is not thread safe [concurrency-mt-unsafe]
|
Clang-tidy:
src/Main/MainGui.cpp#L165
do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
|
Loading