Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to master #35

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Develop to master #35

merged 1 commit into from
Mar 14, 2024

Conversation

devikasuresh20
Copy link
Member

  • Corrected the properties variable name for ANC fetosense test

  • Corrected partner fetosense Id variable name in FeotalMonitorData

  • Corrected GeneratePDF from reportPath

  • Added protocol check condition to identify invalid protocol

  • Added condition to check filepath

  • Added new URL inside condition check

  • Added hostname comparison in foetalMonitor update

  • fetosense update api - generate pdf changes


Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Refactoring
  • Documentation
  • Other ( please specify )

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

* Corrected the properties variable name for ANC fetosense test

* Corrected partner fetosense Id variable name in FeotalMonitorData

* Corrected GeneratePDF from reportPath

* Added protocol check condition to identify invalid protocol

* Added condition to check filepath

* Added new URL inside condition check

* Added hostname comparison in foetalMonitor update

* fetosense update api - generate pdf changes

---------

Co-authored-by: Devika <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ravishanigarapu ravishanigarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@ravishanigarapu ravishanigarapu merged commit 86117a7 into master Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants