-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
birth cert upload #16
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe changes add two new string fields, Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/iemr/flw/domain/identity/RMNCHBornBirthDetails.java (1)
317-324
: The field additions look good, but consider adding constraints.The new fields for storing birth certificate references follow the existing pattern in the class. This implementation allows storing front and back views of birth certificates as strings.
A few suggestions to consider:
- Add
length
constraint to the column definitions to limit potential storage size- Consider adding
nullable = false
if these fields are required- If these fields store file paths or URLs, ensure proper validation to prevent path traversal vulnerabilities
- If these fields will store Base64 encoded content, be aware of potential performance implications with large data in string columns
@Expose @Column(name = "birthCertificateFileFrontView") private String birthCertificateFileFrontView; @Expose @Column(name = "birthCertificateFileBackView") private String birthCertificateFileBackView;
📋 Description
JIRA ID:
Add two column in birthCertificateFileFrontView birthCertificateFileBackView for birth cert upload
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit