Ms2/config versioning #433
Conversation
…versions except the latest disabled
…s2/config_versioning
…s latest" now causes navigation to latest version
This comment has been minimized.
This comment has been minimized.
| versionDescription: string; | ||
| }) => { | ||
| const versionId = v4(); | ||
| await addParentConfigVersion(parentConfig, environment.spaceId, versionId); |
There was a problem hiding this comment.
You should check for a user error.
There was a problem hiding this comment.
What kind of error do you mean?
...gement-system-v2/app/(dashboard)/[environmentId]/machine-config/[configId]/config-editor.tsx
Outdated
Show resolved
Hide resolved
...gement-system-v2/app/(dashboard)/[environmentId]/machine-config/[configId]/config-editor.tsx
Outdated
Show resolved
Hide resolved
| version | ||
| ? (storedData.versionedParentConfigs[parentConfig.id][version] = { | ||
| ...parentConfig, | ||
| targetConfig: targetConfigToStorage(parentConfig.id, targetConfig, newId), | ||
| machineConfigs: machineConfigsToStorage(parentConfig.id, machineConfigs, newId), | ||
| metadata: parametersToStorage(parentConfig.id, 'parent-config', metadata, newId), | ||
| }) | ||
| : (storedData.parentConfigs[parentConfig.id] = { | ||
| ...parentConfig, | ||
| targetConfig: targetConfigToStorage(parentConfig.id, targetConfig, newId), | ||
| machineConfigs: machineConfigsToStorage(parentConfig.id, machineConfigs, newId), | ||
| metadata: parametersToStorage(parentConfig.id, 'parent-config', metadata, newId), | ||
| }); | ||
| } |
There was a problem hiding this comment.
Both of these are storing the same value, you could store it in a variable and the conditionally store it.
Also, since in the lines above you set storedData.versionedParentConfigs[parentConfig.id] = {}, the second case wouldn't happen.
There was a problem hiding this comment.
You are right, but what do you mean when you say the second case wouldn't happen? The conditional branch only depends on the version string which is not changed
| @@ -571,6 +638,23 @@ export async function addParentConfig( | |||
| } | |||
| } | |||
|
|
|||
| // TODO | |||
| export async function setParentConfigVersionAsLatest(machineConfigInput: ParentConfig) { | |||
There was a problem hiding this comment.
Im a bit confused as to what this function does, could you explain it?
There was a problem hiding this comment.
This copies the data of a specific config-version into the editable "main-config" displayed as latest version. This is to provide the same functionality as the process-versions
| @@ -33,6 +34,8 @@ type StoredConfigsAndParameters = { | |||
| machineConfigs: Record<string, StoredMachineConfig>; | |||
| targetConfigs: Record<string, StoredTargetConfig>; | |||
| parameters: Record<string, StoredParameter>; | |||
| // versionedParentConfigs: Record<string, StoredParentConfig>; | |||
| versionedParentConfigs: Record<string, Record<string, StoredParentConfig>>; | |||
There was a problem hiding this comment.
Maybe the versionId should be a part of the config?
There was a problem hiding this comment.
It is. The type StoredParentConfig contains the field version to keep track of the version number.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
Summary
This re-enables the versioning for configs/techdata sets in a similar fashion to the process versioning. This state is usable and presentable eventhough some problems still persist. For example linked parameters are currently not referenced correctly when versioned and also deletion of a config may cause version data to stay unreferenced in storage.
Details
versionedParentConfigsadded to the techdata-storeaddParentConfigVersion()added to store a new version of the current statesetParentConfigVersionAsLatestadded overwrite latest config