Property Panel Undo/Redo Bugfix #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
jjoderis
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the bug which occured when triggering undo/redo for metaData values in property panel (e.g. milestones)
Details
When triggering undo/redo, the event system in bpmn.js looks for changes in selected element object. The function setProceedElement for adding changes uses an in-place mechanism to write changes into element. This behaviour leads to bpmn.js not recognising changes for the element. The solution of this bug was to create a deep copy of the selected element and change attributes before transmitting this object to the event queue of bpmn.js.