-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial mqtt calls for endpoints #403
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjoderis did you have a mqtt broker running and the env vars set? |
Ah i see. No i didn't. Would it be a valid option to hide the entry from the Dashboard if the mqtt environment values are not set? From what i understand the route cannot work without them. |
I think it would be better to show a message that mqtt isn't set up, what do you think? I remember Kai saying that he wanted the mqtt credentials in the environment variables, I think for now it is ok. |
I see. I think a specific message about mqtt not being set up would possibly improve the user experience. |
This comment has been minimized.
This comment has been minimized.
✅ Successfully created Preview Deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe add a some comments to your typescript endpoint helpers to make it easier to grasp what they do and they work.
type Endpoints = EndpointSchema; | ||
type Methods = 'get' | 'post' | 'put' | 'delete'; | ||
|
||
type GetParamsFromString< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe add one or two comments to this file to explain what exactly these types do.
And is "Count" actually a fitting name? I looks like it is a list of all arguments that are behind a ":" in the string.
Summary
Initial implementation of mqtt requests for engines and overview of engines for admins.