New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ms2/config editor layout overhaul #400

Merged

FelipeTrost merged 21 commits into main from ms2/config-editor-layout-overhaul

Jan 20, 2025

Contributor

canptura commented Oct 24, 2024

Summary

This aims to improve the styling and readability of the config editor.

Details

capitalization of displayed keys removed

config-content

improved show/hide ID button
improved card styling for parameters and nested parameters
display of nested parameters now row-wise to save horizontal space

config-editor

improved panel styling
machine configs are now displayed as expanded by default
improved card styling for target and machine configs
delete button added to target configs

create-parameter-modal

displayname is no longer a required field
- default value added
fields for the new entry are now visually separated and displayed in a card

configuration-helper

defaultparameter() now receive an additional parameter disName to set the display name
- key now defines the new parameters key - not the display name anymore
defaultParentConfiguration() was added
- Parameters: name: string, description: string, folderId: string - similar to defaultMachineConfiguration() & defaultTargetConfiguration()

action-buttons

copy & edit buttons are now also only shown while editable === true

Schemas & Types

key: string added to ParameterZod Schema
refactoring of machine-config-schema.ts
ParentConfigMetadata is now ParentConfig
Types that are not longer exported:
- AbstractConfigServerInput
- StoredAbstractConfigServerInput
- StoredAbstractConfigMetadata
removed Schemas:
- StoredAbstractConfigInputSchema
removed Types:
- StoredAbstractConfigInput
- AbstractConfigMetadata
- StoredAbstractConfig
- ParentConfigMetadata
- StoredParentConfigMetadata
- MachineConfigMetadata
- StoredMachineConfigMetadata
- TargetConfigMetadata
- StoredTargetConfigMetadata

refactoring of names

MachineConfigModal is now ConfigModal
MachineConfigCreationButton is now ConfigCreationButton

canptura added 9 commits

October 2, 2024 18:49


          styling for parameter keys and nested parameter cards changed

45e1fb2


          editor style improvements

e59a78c


          editor layout now more compact

2f6512b


          "defaultParameter"-function rework

cf599ea


          refactoring of types and component names, also small styling improvem…

6847b8f

…ents for config editor


          nesting indentation fixed

d66d5da


          Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into m…

1c4754d

…s2/config-editor-layout-overhaul


          show/hide internal ID toolip improved

99cf4ae


          Action Button added to Target Config in Editor

7fe46c3

This comment has been minimized.

Sign in to view


          Merge branch 'main' into ms2/config-editor-layout-overhaul

583d434

This comment has been minimized.

Sign in to view

canptura added 2 commits

October 31, 2024 13:06


          Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into m…

b1aca93

…s2/config-editor-layout-overhaul


          Merge branch 'ms2/config-editor-layout-overhaul' of https://github.co…

c4a0eda

…m/PROCEED-Labs/proceed into ms2/config-editor-layout-overhaul

This comment has been minimized.

Sign in to view


          Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into m…

aa9b230

…s2/config-editor-layout-overhaul

This comment has been minimized.

Sign in to view


          Merge branch 'main' into ms2/config-editor-layout-overhaul

4972d1e

FelipeTrost self-assigned this

This comment has been minimized.

Sign in to view

FelipeTrost requested changes

View reviewed changes

Contributor

FelipeTrost left a comment

There are some minor issues that need addressing.

...nagement-system-v2/app/(dashboard)/[environmentId]/machine-config/[configId]/mach-config.tsx Outdated Show resolved Hide resolved

src/management-system-v2/components/config-creation-button.tsx Outdated Show resolved Hide resolved

src/management-system-v2/app/(dashboard)/[environmentId]/machine-config/parent-config-list.tsx Show resolved Hide resolved

src/management-system-v2/lib/data/legacy/machine-config.ts Outdated Show resolved Hide resolved


          Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into m…

89b6148

…s2/config-editor-layout-overhaul

This comment has been minimized.

Sign in to view


          removed old debug code and comments

fc23fb5

This comment has been minimized.

Sign in to view


          unnecessary useRef removed

f86105f

This comment has been minimized.

Sign in to view


          config creation modal now supports arrow key inputs

47b57af

This comment has been minimized.

Sign in to view


          missing description on creation fixed

3db9166


          Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into m…

9d865d1

…s2/config-editor-layout-overhaul

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          Merge branch 'main' into ms2/config-editor-layout-overhaul

github-actions bot commented Jan 20, 2025

✅ Successfully created Preview Deployment.

https://pr-400---ms-server-staging-c4f6qdpj7q-ew.a.run.app

FelipeTrost approved these changes

View reviewed changes

FelipeTrost merged commit 878af1f into main

15 checks passed

FelipeTrost deleted the ms2/config-editor-layout-overhaul branch

January 20, 2025 12:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet