ms2: creation modals bug #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jjoderis
previously approved these changes
Nov 17, 2024
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
jjoderis
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #359
Summary
The issue was that rc-menu supports arrow movements and prevents the default of the event to avoid the page from scrolling.
Since the
ProcessCreationButtonandFolderCreationButtonwere inside such menus, the event listeners also applied to them and disabled the default behaviors of arrow movements.This behavior can only be turned off by setting the mode of the menu to
inline, butinlinemode is not supported for our use cases of the menus.The simplest solution was to refactor the Modals so that they were outside the menus.