Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms2/select role folder #362

Merged
merged 20 commits into from
Dec 6, 2024
Merged

ms2/select role folder #362

merged 20 commits into from
Dec 6, 2024

Conversation

FelipeTrost
Copy link
Contributor

@FelipeTrost FelipeTrost commented Aug 14, 2024

closes #212

Summary

Added a way to select what folder a role should act on.

Details

  • role general-data: choose role folder
  • useParseZodErrors: avoid unnecessary rerenders**
  • refactor FormSubmitButton
  • fixed abilities check: use folderId when checking processes
  • getFolder: return root if no id
  • FolderTree
    • fixed prop type
    • added option to show root folder as a folder, this only would work if no initial folders where passed
    • added minheight, since otherwise the spinner floats over the element on top of the tree
    • to prevent overflow I added overflow: 'hidden', I tried to wrap the words, but I didn't manage to pull it off

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.


if (!rootNode) return;

rootNode.style;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long, I removed it

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Dec 5, 2024

CLOUDRUN ACTIONS

✅ Successfully created Preview Deployment.

https://pr-362---ms-server-staging-c4f6qdpj7q-ew.a.run.app

@OhKai OhKai merged commit 4bb4f72 into main Dec 6, 2024
15 checks passed
@OhKai OhKai deleted the ms2/select-role-folder branch December 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an "Environment" for every Company and every User account
2 participants