Ms2/process list fixes #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the updateFolder function was using the parent folder id
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
OhKai
requested changes
May 26, 2024
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
MaxiLein
added a commit
that referenced
this pull request
Jun 4, 2024
* refactor(folder-schema): changed properties to match processes * fix(folders): environmentId cannot be changed * fix(fuzzy-search): value is always a string * fix(processes): update correct folder the updateFolder function was using the parent folder id * fix(unit-tests:folders): filter folders correctly * feat(process-list): all columns except description can be sorted * feat(process-list): name column cannot be deselected * fix(e2e-tests): deleted Name column from tests because it cannot be toggled anymore
OhKai
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Ms2/process list fixes (#283) * refactor(folder-schema): changed properties to match processes * fix(folders): environmentId cannot be changed * fix(fuzzy-search): value is always a string * fix(processes): update correct folder the updateFolder function was using the parent folder id * fix(unit-tests:folders): filter folders correctly * feat(process-list): all columns except description can be sorted * feat(process-list): name column cannot be deselected * fix(e2e-tests): deleted Name column from tests because it cannot be toggled anymore * updated scrollbar * added container for scrollbar * removed console.log's * added lazy viewer * added proceed loading indicator * shrink loading indicator * adress requested changes * only animate visible loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves some points of #259
Folders
updatedAt -> lastEditedcreatedAt -> createdOnProcess list
Fuzy search