Responsive design process list #204
Conversation
…usted mobile menu, adjusted information button
…ton to float button in mobile view
| <SiderMenu /> | ||
| // <Menu theme="light" mode="inline" selectedKeys={[activeSegment]}> | ||
| // {ability.can('view', 'Process') || ability.can('view', 'Template') ? ( | ||
| // <> | ||
| // <ProcessSider></ProcessSider> | ||
| // <Divider /> | ||
| // </> | ||
| // ) : null} |
There was a problem hiding this comment.
If you refactor / change parts of the code that are not just temporary, you can confidently remove those and don't need to comment everything out.
We can always go back in the commit history to get removed code back :)
There was a problem hiding this comment.
Noted! Thanks a lot! :)
There was a problem hiding this comment.
Can menu-mobile.tsx and this file be refactored into one component? They seem very similar.
There was a problem hiding this comment.
menu-sider was refactored to include menu-mobile. The components are now also visible in the mobile-menu as I haven't found a good work-around about how to exclude them there, yet.
| type ProcessImportButtonProps = ButtonProps | ||
|
|
There was a problem hiding this comment.
Why can't we use ButtonProps directly?
There was a problem hiding this comment.
It's used directly now!
| const [importProcessData, setImportProcessData] = useState<ProcessData[]>([]); | ||
| const router = useRouter(); | ||
| console.log(importProcessData) |
There was a problem hiding this comment.
console.log was removed
Summary
- Order in mobile view: search bar - action bar - list/ icon view, separate float button for import and create
- Order outside of mobile view: action bar - search bar - import button - create button - list/ icon view - info button
Details