Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ms2/modeler selection export #199

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Ms2/modeler selection export #199

merged 7 commits into from
Dec 19, 2023

Conversation

jjoderis
Copy link
Contributor

Summary

Related to: #144

Improved the export handling when exporting from the modeler by adding support for partial export only of selected elements (and elements nested inside them) and by considering which layer of the process is open when the export is triggered

Also added a config for debugging the frontend of the new MS in vscode

Details

  • Fixed: lanes cannot be found by our bpmn helper functions
  • Fixed: running getElementDI on a diagram that has an empty layer leads to an error
  • if a user has elements in the modeler selected opens the export modal and selects an image type for the export an option to export only the selection is given
    • exporting only the selection will remove the visualization of all elements that are not selected and also not nested inside a selected element
    • imports that are used by call activities outside the selection are also excluded from the export
    • the layers of subprocesses outside the selection are also excluded from the export
  • if the layer of a collapsed subprocess is open in the modeler when the export modal is opened that layer is considered the root of the export when an image export is selected
    • all layers not nested under the current layer are not exported (including the layer of the root process)
    • imports and subprocesses inside layers that are not exported are also not exported
  • imports used by call-activities inside nested collapsed subprocesses are no longer exported when the collapsed subprocesses themselves are not exported

…he DI of an element in a bpmn with an empty collapsed subprocess leads to an error
…and the respective export option is selected. Related to #144
…and if collapsed subprocesses or imports should be exported only those nested under the current layer. Related to #144
Comment on lines +38 to +42

/**
* When given an array type returns the type of an element inside the array
*/
export type ArrayEntryType<T extends any[]> = T extends Array<infer EntryType> ? EntryType : never;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, you can achieve the same by ArrayType[number]

@OhKai OhKai merged commit 7b4a7c4 into main Dec 19, 2023
11 checks passed
@OhKai OhKai deleted the ms2/modeler-selection-export branch December 19, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants