Ms2/modeler share modal #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoderis
requested changes
Dec 14, 2023
src/management-system-v2/components/modeler-share-modal-option-public-link.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/components/modeler-share-modal-option-public-link.tsx
Outdated
Show resolved
Hide resolved
FelipeTrost
requested changes
Dec 15, 2023
src/management-system-v2/components/modeler-share-modal-option-embed-in-web.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/components/modeler-share-modal-option-embed-in-web.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/components/modeler-share-modal-option-embed-in-web.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/components/modeler-share-modal-option-public-link.tsx
Outdated
Show resolved
Hide resolved
FelipeTrost
requested changes
Dec 22, 2023
src/management-system-v2/app/api/share/generate-share-token/route.ts
Outdated
Show resolved
Hide resolved
src/management-system-v2/app/api/share/generate-share-token/route.ts
Outdated
Show resolved
Hide resolved
src/management-system-v2/app/api/share/validate-share-token/route.ts
Outdated
Show resolved
Hide resolved
src/management-system-v2/components/modeler-share-modal-option-embed-in-web.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/components/modeler-share-modal-option-public-link.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/components/modeler-share-modal-option-public-link.tsx
Outdated
Show resolved
Hide resolved
jjoderis
approved these changes
Jan 8, 2024
jjoderis
requested changes
Jan 8, 2024
The environment variable JWT_KEY= needs to be defined in .env.local file. |
jjoderis
previously approved these changes
Jan 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… the platform in the current context, possibly because the user denied permission
… the platform in the current context, possibly because the user denied permission
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jjoderis
previously approved these changes
Apr 17, 2024
|
✅ Successfully created Preview Deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created the outline of the share dialog, tried to make it responsive as well.
Need to work on actual functionality of share public link and embed in website
Copy to Diagram Clipboard, Copy BPMN to Clipboard, Export as file work and leverage the functions implemented by Janis.