Adjust copy and delete #174
Conversation
…lete modal, adjusted copy modal, added copy function to process list right hand icons
…creens starting breakpoint sm
… for both delete and copy
|
Popconfirm should be replaced by confirmation-button, for which you have to wait until this pr is merged. |
| type="text" | ||
| style={{ marginTop: '20px', marginLeft: '15px' }} | ||
| icon={<MenuOutlined style={{ fontSize: '170%' }} />} | ||
| /> | ||
| onClick={() => !siderOpened} |
There was a problem hiding this comment.
What does the onClick Function do?
There was a problem hiding this comment.
Removed the onClick function as it's not used anymore
| }); | ||
| }); | ||
| setSelection([]); | ||
| }, [deleteProcess, selection]); |
There was a problem hiding this comment.
Missing dependency: setSelection
There was a problem hiding this comment.
Missing dependency was added
|
|
||
| <AuthCan action="delete" resource={toCaslResource('Process', process)}> | ||
| <Tooltip placement="top" title={'Delete'}> | ||
| <Popconfirm |
There was a problem hiding this comment.
Can you use ConfirmationButton instead of PopConfirm
| @@ -103,6 +112,20 @@ const ProcessList: FC<ProcessListProps> = ({ | |||
| onSettled: refreshData, | |||
| }); | |||
|
|
|||
| const deleteSelectedProcesses = useCallback(() => { | |||
There was a problem hiding this comment.
you could move this function to processes and use it together with ConfirmationButton, then you could delete the process-delete components
There was a problem hiding this comment.
Used deleteSelectedProcesses function from processes.tsx and declared its type as "Dispatch<SetStateAction<Key[]>>" in process-list.tsx. However, this declaration shows the error "Expected 1 arguments, but got 0." Would there be a better type to declare it as?
|
Once @FelipeTrost is happy with his review, I can take care of the merge conflicts with main, since I changed a lot with the switch to Server Components. |
Summary
Added copy function to process-list's action bar and replaced process-delete module in processes.tsx and process-list.tsx with pop-confirmations --> resulting in error for both delete and copy (todo!)
Adjusted mobile view for screensize <= sm