Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process BPMN Import (New MS) #170

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Process BPMN Import (New MS) #170

merged 9 commits into from
Dec 1, 2023

Conversation

jjoderis
Copy link
Contributor

Summary

  • Added the functionality to import processes from one or multiple BPMN files

Details

  • generalized the process creation from existing data out of the process-copy-modal
  • reimplemented the process-copy-modal with the new process-creation-modal
  • implemented a process-import modal with the process creation modal
  • added a Process Import button to the sidebar in the Process List sub-menu
  • clicking the button opens a file browser that allows selecting BPMN files
  • after file selection is finished the process-import-modal is opened and allows changes to some of the meta data of the imports
  • increased the amount of data allowed in a request to allow import of larger BPMN files (>100kb)

OhKai
OhKai previously approved these changes Nov 30, 2023
Copy link
Contributor

@OhKai OhKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future we should probably do the refactoring where all the process related stuff gets moved into the processes page folder.

@OhKai
Copy link
Contributor

OhKai commented Nov 30, 2023

@jjoderis Please resolve the conflicts, then it can be merged.

@OhKai OhKai merged commit cb050b1 into main Dec 1, 2023
2 checks passed
@OhKai OhKai deleted the ms2/process-import branch December 1, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants