Ms2/process editor #126
Merged
Ms2/process editor #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeTrost
requested changes
Oct 23, 2023
| @@ -119,9 +117,9 @@ const Processes: FC<ProcessProps> = () => { | |||
| {menu} | |||
| <Divider style={{ margin: '4px 0' }} /> | |||
| <Space style={{ display: 'flex', justifyContent: 'center' }}> | |||
| <Button type="text" icon={<PlusOutlined />} onClick={createProcess}> | |||
| <ProcessCreationButton type="text" icon={<PlusOutlined />}> | |||
There was a problem hiding this comment.
Permission check is missing (AuthCan)
There was a problem hiding this comment.
This is also the case in version-toolbar.tsx:199
| @@ -61,7 +61,7 @@ const Modeler: FC<ModelerProps> = ({ minimized, ...props }) => { | |||
| // This is not the most recent instance, so don't do anything. | |||
| if (active !== modeler.current) return; | |||
|
|
|||
| if (editingDisabled) { | |||
There was a problem hiding this comment.
editingDisabled seems to be unused
| return ( | ||
| <Modal | ||
| title="Create new Process" |
There was a problem hiding this comment.
Modal close button on the top right gets in the way of the text, maybe closeIcon={null} is a good solution
FelipeTrost
approved these changes
Oct 23, 2023
| @@ -154,23 +196,26 @@ const VersionToolbar: React.FC<VersionToolbarProps> = () => { | |||
| <div style={{ position: 'absolute', zIndex: 10, padding: '12px', top: '80px' }}> | |||
| <Space.Compact size="large" direction="vertical"> | |||
| <Tooltip title="Create as new process"> | |||
| <Button icon={<PlusOutlined />} onClick={openNewProcessModal}></Button> | |||
| <ProcessCreationButton | |||
There was a problem hiding this comment.
Permission check is missing (AuthCan)
| @@ -119,9 +117,9 @@ const Processes: FC<ProcessProps> = () => { | |||
| {menu} | |||
| <Divider style={{ margin: '4px 0' }} /> | |||
| <Space style={{ display: 'flex', justifyContent: 'center' }}> | |||
| <Button type="text" icon={<PlusOutlined />} onClick={createProcess}> | |||
| <ProcessCreationButton type="text" icon={<PlusOutlined />}> | |||
There was a problem hiding this comment.
This is also the case in version-toolbar.tsx:199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor bugfixes in process editor concerning process versions. Processes can be added now from scratch in overview page.
Details