-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bpmn helper update #111
Bpmn helper update #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some situations like milestones and callActivities we might expect values to exist when the bpmn is valid. But a bpmn might contain a milestone without a name which is not reflected by the current annotations.
Should every value be set to optional that could have an edge-case where it might not be present even if we expect it to generally exist?
Absolutely, any value that can be optional must be denoted as such. It is the responsibility of the caller to ensure the safe usage of these values by either
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Adapted bpmn-helper module for use in typescript environment. JSDoc comments have been extended and there have been generated declaration files based on these to use in typescript files.
Details