Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitions added #124

Closed
wants to merge 15 commits into from
Closed

Definitions added #124

wants to merge 15 commits into from

Conversation

nithujohn
Copy link
Collaborator

@nithujohn nithujohn commented Feb 13, 2025

User description

Hi @ypriverol there are few terms I can't find definitions. I am posting it down.
[Term]
id: PRIDE:0000058
name: z

[Term]
id: PRIDE:0000089
name: Protonated setting Mr

[Term]
id: PRIDE:0000367
name: subsample 1 description

[Term]
id: PRIDE:0000368
name: subsample 2 description

[Term]
id: PRIDE:0000369
name: subsample 3 description

[Term]
id: PRIDE:0000370
name: subsample 4 description

[Term]
id: PRIDE:0000371
name: subsample 5 description

[Term]
id: PRIDE:0000372
name: subsample 6 description

[Term]
id: PRIDE:0000373
name: subsample 7 description

[Term]
id: PRIDE:0000374
name: subsample 8 description

[Term]
id: PRIDE:0000375
name: standard deviation subsample 1

[Term]
id: PRIDE:0000376
name: standard deviation subsample 2

[Term]
id: PRIDE:0000377
name: standard deviation subsample 3

[Term]
id: PRIDE:0000378
name: standard deviation subsample 4

[Term]
id: PRIDE:0000379
name: standard deviation subsample 5

[Term]
id: PRIDE:0000380
name: standard deviation subsample 6

[Term]
id: PRIDE:0000381
name: standard deviation subsample 7

[Term]
id: PRIDE:0000382
name: standard deviation subsample 8

id: PRIDE:0000383
name: standard error subsample 1

[Term]
id: PRIDE:0000384
name: standard error subsample 2

[Term]
id: PRIDE:0000385
name: standard error subsample 3

[Term]
id: PRIDE:0000386
name: Standard error subsample 4

[Term]
id: PRIDE:0000387
name: standard error subsample 5

[Term]
id: PRIDE:0000388
name: standard error subsample 6

[Term]
id: PRIDE:0000389
name: standard error subsample 7

[Term]
id: PRIDE:0000390
name: standard error subsample 8

[Term]
id: PRIDE:0000391
name: quantification parameter


PR Type

Documentation


Description

  • Added detailed definitions for numerous PRIDE ontology terms.

  • Updated ontology metadata, including version and date.

  • Introduced new terms and restructured existing ones for clarity.

  • Enhanced descriptions for Olink instruments and quantification methods.


Changes walkthrough 📝

Relevant files
Documentation
pride_cv.obo
Added definitions and updated ontology terms                         

pride_cv.obo

  • Replaced comments with detailed definitions for ontology terms.
  • Updated metadata fields like data-version and date.
  • Added new terms for Olink instruments and quantification methods.
  • Improved descriptions for existing terms to enhance clarity.
  • +161/-82
    Additional files
    pride_cv.owl +1010/-84

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    coderabbitai bot commented Feb 13, 2025

    Important

    Review skipped

    Auto reviews are disabled on base/target branches other than the default branch.

    Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

    You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


    🪧 Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>, please review it.
      • Generate unit testing code for this file.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
      • @coderabbitai generate unit testing code for this file.
      • @coderabbitai modularize this function.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
      • @coderabbitai read src/utils.ts and generate unit testing code.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
      • @coderabbitai help me debug CodeRabbit configuration file.

    Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

    CodeRabbit Commands (Invoked using PR comments)

    • @coderabbitai pause to pause the reviews on a PR.
    • @coderabbitai resume to resume the paused reviews.
    • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
    • @coderabbitai full review to do a full review from scratch and review all the files again.
    • @coderabbitai summary to regenerate the summary of the PR.
    • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
    • @coderabbitai resolve resolve all the CodeRabbit review comments.
    • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
    • @coderabbitai help to get help.

    Other keywords and placeholders

    • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
    • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
    • Add @coderabbitai anywhere in the PR title to generate the title automatically.

    CodeRabbit Configuration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Documentation and Community

    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Incorrect Definition

    The definition for MS2 based isotope labeling (PRIDE:0000317) incorrectly states it is detectable at MS1 level, but it should be MS2 level based on the term name and usage.

    def: "Describes isotope labeling quantification techniques detectable at MS1 level." [PRIDE:PRIDE]
    Syntax Error

    The definition for TMT reagent 88 (PRIDE:0000560) has an incorrectly formatted citation with missing closing bracket [PRIDE;PRIDE] instead of [PRIDE:PRIDE].

    def: "protonated setting MH⁺ refers to the protonated molecular ion of a compound, where M represents the neutral molecule, and the H⁺ signifies the added proton." [PRIDE;PRIDE]

    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix definition syntax error

    Fix incorrect syntax in protonated setting MH+ definition - semicolon used
    instead of colon

    pride_cv.obo [560]

    -def: "protonated setting MH⁺ refers to the protonated molecular ion of a compound, where M represents the neutral molecule, and the H⁺ signifies the added proton." [PRIDE;PRIDE]
    +def: "protonated setting MH⁺ refers to the protonated molecular ion of a compound, where M represents the neutral molecule, and the H⁺ signifies the added proton." [PRIDE:PRIDE]
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    __

    Why: Corrects an incorrect syntax in the ontology definition format (semicolon instead of colon), which could potentially cause issues with ontology parsing tools.

    Low
    Fix definition typo

    Fix typo in definition of 'Precursor ion mass tolerance' - change "efines" to
    "defines"

    pride_cv.owl [480]

    -<obo:IAO_0000115 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Precursor ion mass tolerance efines the acceptable range of deviation between the experimental mass-to-charge ratio (𝑚/𝑧)of a precursor ion and its theoretical (m/z) value during database searches</obo:IAO_0000115>
    +<obo:IAO_0000115 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Precursor ion mass tolerance defines the acceptable range of deviation between the experimental mass-to-charge ratio (𝑚/𝑧)of a precursor ion and its theoretical (m/z) value during database searches</obo:IAO_0000115>
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    __

    Why: The suggestion fixes a clear typo in the definition text ("efines" -> "defines"), which improves readability and professionalism of the documentation.

    Low
    Fix definition typo

    Fix typo in definition of precursor ion mass tolerance term - "efines" should be
    "defines"

    pride_cv.obo [74]

    -def: "Precursor ion mass tolerance efines the acceptable range of deviation between the experimental mass-to-charge ratio (𝑚/𝑧)of a precursor ion and its theoretical (m/z) value during database searches" [PRIDE:PRIDE]
    +def: "Precursor ion mass tolerance defines the acceptable range of deviation between the experimental mass-to-charge ratio (𝑚/𝑧) of a precursor ion and its theoretical (m/z) value during database searches" [PRIDE:PRIDE]
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    __

    Why: Fixes a minor typo in the definition text that could affect readability and professionalism of the documentation, though not impacting functionality.

    Low

    @nithujohn nithujohn closed this Feb 13, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants