Ignore some words probably not part of place names

Refs #31
PREreview · Jul 11, 2024 · 53fb87a · 53fb87a
1 parent fc0f070
commit 53fb87a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/lib/Iso3166.ts b/src/lib/Iso3166.ts
@@ -20,6 +20,7 @@ export const guessCountry: (location: string) => Option.Option<Alpha2Code> = flo
   String.replaceAll(/\((.+?)\)/g, ', $1'),
   String.replaceAll(/ [0-9]+/g, ' '),
   String.replaceAll(/( and | - )/gi, ', '),
+  String.replaceAll(/(^| )(the|near) /gi, ''),
   location => Array.prepend(Array.map(location.split(',').reverse(), String.trim), location),
   Array.findFirst(location =>
     Option.fromNullable(iso3166.getAlpha2Code(location, 'en')).pipe(

diff --git a/test/Iso3166.test.ts b/test/Iso3166.test.ts
@@ -12,6 +12,7 @@ describe('guessCountry', () => {
     ['Czech Republic', 'CZ'],
     ['Czechia', 'CZ'],
     ['Düsseldorf', 'DE'],
+    ['Fayetteville GA (near Atlanta)', 'US'],
     ['GHANA', 'GH'],
     ['London', 'GB'],
     ['London, Ontario', 'CA'],
@@ -22,6 +23,7 @@ describe('guessCountry', () => {
     ['Québec', 'CA'],
     ['Rio de Janeiro, Brazil.', 'BR'],
     ['Sunnyvale, California', 'US'],
+    ['The UK', 'GB'],
     ['UK', 'GB'],
     ['U.K.', 'GB'],
     ['United Kingdom', 'GB'],
@@ -33,12 +35,9 @@ describe('guessCountry', () => {
     expect(actual).toStrictEqual(Option.some(expected))
   })
 
-  test.for(['Babol iran', 'Fayetteville GA (near Atlanta)', 'Mars', 'Southeast Asia', 'The UK', 'Yale university'])(
-    "doesn't guess %s",
-    input => {
-      const actual = _.guessCountry(input)
+  test.for(['Babol iran', 'Mars', 'Southeast Asia', 'Yale university'])("doesn't guess %s", input => {
+    const actual = _.guessCountry(input)
 
-      expect(actual).toStrictEqual(Option.none())
-    },
-  )
+    expect(actual).toStrictEqual(Option.none())
+  })
 })