Skip to content

Commit

Permalink
Use a consistent version of Node
Browse files Browse the repository at this point in the history
  • Loading branch information
thewilkybarkid committed Jan 7, 2025
1 parent dbb9871 commit 0f551a3
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 18 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
key: data-${{ hashFiles('src/data/*') }}-${{ steps.date.outputs.date }}

- name: 'Install dependencies'
run: npm ci
run: npm ci --engine-strict

- name: 'Build dist'
run: npx observable build
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
cache: ${{ !env.ACT && 'npm' || '' }}

- name: 'Install dependencies'
run: npm ci
run: npm ci --engine-strict

- name: 'Run formatter'
run: npx prettier --ignore-unknown --check '**'
Expand All @@ -137,7 +137,7 @@ jobs:
cache: ${{ !env.ACT && 'npm' || '' }}

- name: 'Install dependencies'
run: npm ci
run: npm ci --engine-strict

- name: 'Run the linter'
run: npx eslint . --max-warnings 0
Expand All @@ -159,7 +159,7 @@ jobs:
cache: ${{ !env.ACT && 'npm' || '' }}

- name: 'Install dependencies'
run: npm ci
run: npm ci --engine-strict

- name: 'Run the tests'
run: npx vitest run
Expand All @@ -183,7 +183,7 @@ jobs:
cache: ${{ !env.ACT && 'npm' || '' }}

- name: 'Install dependencies'
run: npm ci
run: npm ci --engine-strict

- name: 'Download dist'
uses: actions/[email protected]
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
cache: ${{ !env.ACT && 'npm' || '' }}

- name: 'Install dependencies'
run: npm ci
run: npm ci --engine-strict

- name: 'Run typechecker'
run: npx tsc --noEmit
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fix-playwright-versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
cache: ${{ !env.ACT && 'npm' || '' }}

- name: 'Install dependencies'
run: npm ci --ignore-scripts
run: npm ci --engine-strict --ignore-scripts

- name: 'Fix Playwright versions'
run: scripts/fix-playwright-versions.sh
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ IMAGE_TAG=prereview-stats
export OBSERVABLE_TELEMETRY_DISABLE := 1

node_modules: package.json package-lock.json
npm install
npm install --engine-strict
touch node_modules

.env:
Expand Down
17 changes: 10 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@dotenvx/dotenvx": "^1.32.0",
"@playwright/test": "^1.49.1",
"@trivago/prettier-plugin-sort-imports": "^5.2.1",
"@tsconfig/node20": "^20.1.4",
"@tsconfig/node22": "^22.0.0",
"@types/all-the-cities": "^3.1.3",
"@types/diacritics": "^1.3.3",
"@types/node": "^22.10.5",
Expand All @@ -41,6 +41,7 @@
"vitest": "^2.1.8"
},
"engines": {
"node": ">=18"
"node": "22",
"npm": "9 || 10"
}
}
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node20/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"compilerOptions": {
"exactOptionalPropertyTypes": true,
"resolveJsonModule": true
Expand Down

0 comments on commit 0f551a3

Please sign in to comment.