-
Notifications
You must be signed in to change notification settings - Fork 12
Fixing the COVID-19 tag, putting it at the top of diseases list #107
Conversation
…e list of disease subject tags, also added styling pizzazz
… added some styling pizzazz to highlight it
src/constants.js
Outdated
@@ -203,7 +203,7 @@ export const DISEASES = [ | |||
|
|||
{ | |||
name: '2019 novel coronavirus', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is also technically incorrect, as "2019 novel coronavirus" is the name of the pathogen, not the disease. Let me know if you'd like this fixed as well, @georgiamoon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! The team made a mistake earlier this year when they named it that. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okie, just changed it to "Coronavirus disease 2019" for the disease name.
src/constants.js
Outdated
@@ -137,6 +137,12 @@ export const INDEXED_PREPRINT_PROPS = [ | |||
|
|||
// See https://github.com/PREreview/rapid-prereview/issues/10 | |||
export const DISEASES = [ | |||
{ | |||
name: '2019 novel coronavirus', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@majohansson Should we have the name '2019 novel coronavirus' at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't display in the interface, but I'm wondering if it should just be 'COVID-19' fullstop.
As far as my ability to read the code, this all LGTM. I pinged @majohansson on the name/alt name for COVID-19, but from my perspective this is good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. LGTM!
Fixes #96.
This is a product of pairing with @rudietuesdays!
For now, we hard coded COVID-19 into the top of the DISEASES constant that populates the disease subject tag list. We added some styling to highlight it.
For a future feature, we would want to add a "featured" flag or something to diseases so that putting them at the top of the list can be done programatically.