Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Fixing the COVID-19 tag, putting it at the top of diseases list #107

Merged
merged 4 commits into from
Jun 9, 2020

Conversation

harumhelmy
Copy link
Contributor

@harumhelmy harumhelmy commented May 15, 2020

Fixes #96.

This is a product of pairing with @rudietuesdays!

For now, we hard coded COVID-19 into the top of the DISEASES constant that populates the disease subject tag list. We added some styling to highlight it.

For a future feature, we would want to add a "featured" flag or something to diseases so that putting them at the top of the list can be done programatically.

Screen Shot 2020-05-15 at 16 28 33

Screen Shot 2020-05-15 at 16 29 02

@harumhelmy harumhelmy marked this pull request as ready for review May 15, 2020 19:38
@harumhelmy harumhelmy assigned harumhelmy and unassigned harumhelmy May 15, 2020
@harumhelmy harumhelmy changed the title WIP: Fixing the COVID-19 tag Fixing the COVID-19 tag, putting it at the top of diseases list May 15, 2020
src/constants.js Outdated
@@ -203,7 +203,7 @@ export const DISEASES = [

{
name: '2019 novel coronavirus',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is also technically incorrect, as "2019 novel coronavirus" is the name of the pathogen, not the disease. Let me know if you'd like this fixed as well, @georgiamoon!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! The team made a mistake earlier this year when they named it that. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie, just changed it to "Coronavirus disease 2019" for the disease name.

src/constants.js Outdated
@@ -137,6 +137,12 @@ export const INDEXED_PREPRINT_PROPS = [

// See https://github.com/PREreview/rapid-prereview/issues/10
export const DISEASES = [
{
name: '2019 novel coronavirus',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majohansson Should we have the name '2019 novel coronavirus' at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't display in the interface, but I'm wondering if it should just be 'COVID-19' fullstop.

@georgiamoon
Copy link
Member

As far as my ability to read the code, this all LGTM. I pinged @majohansson on the name/alt name for COVID-19, but from my perspective this is good to merge.

@harumhelmy harumhelmy marked this pull request as draft May 18, 2020 21:53
Copy link
Contributor

@jheretic jheretic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM!

@jheretic jheretic merged commit 7ec6680 into PREreview:master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COVID-19 tag at the beginning of the tag list
3 participants