Fix paths beginning with a double slash

CI started failing as there was an unexpected update to fast-check. This version now generates URLs containing '//' as the beginning of the path, which then break's constructing URL objects which consider it to be an invalid protocol relative URL. Refs #1834, 8f6b150, dubzzz/fast-check#4896
PREreview · Aug 28, 2024 · 3fc0404 · 3fc0404
1 parent e6c1fb1
commit 3fc0404
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/response.ts b/src/response.ts
@@ -242,7 +242,8 @@ export const handlePageResponse = ({
         match(response.canonical)
           .with(P.string, canonical =>
             R.asks(
-              ({ publicUrl }: PublicUrlEnv) => new URL(encodeURI(canonical).replace(/^([^/])/, '/$1'), publicUrl).href,
+              ({ publicUrl }: PublicUrlEnv) =>
+                new URL(`${publicUrl.origin}${encodeURI(canonical).replace(/^([^/])/, '/$1')}`).href,
             ),
           )
           .with(undefined, R.of)
@@ -307,7 +308,7 @@ const handleTwoUpPageResponse = ({
       'canonical',
       RM.asks(
         ({ publicUrl }: PublicUrlEnv) =>
-          new URL(encodeURI(response.canonical).replace(/^([^/])/, '/$1'), publicUrl).href,
+          new URL(`${publicUrl.origin}${encodeURI(response.canonical).replace(/^([^/])/, '/$1')}`).href,
       ),
     ),
     RM.bindW(
@@ -376,7 +377,7 @@ const handleLogInResponse = ({
   response: LogInResponse
 }): RM.ReaderMiddleware<OrcidOAuthEnv & PublicUrlEnv, StatusOpen, ResponseEnded, never, void> =>
   pipe(
-    RM.asks(({ publicUrl }: PublicUrlEnv) => new URL(response.location, publicUrl).href),
+    RM.asks(({ publicUrl }: PublicUrlEnv) => new URL(`${publicUrl.origin}${response.location}`).href),
     RM.ichainW(requestAuthorizationCode('/authenticate')),
     R.local(addRedirectUri()),
   )

diff --git a/test/response.test.ts b/test/response.test.ts
@@ -609,7 +609,7 @@ describe('handleResponse', () => {
                   response_type: 'code',
                   redirect_uri: new URL('/orcid', publicUrl).toString(),
                   scope: '/authenticate',
-                  state: new URL(response.location, publicUrl).href,
+                  state: new URL(`${publicUrl.origin}${response.location}`).href,
                 }).toString()}`,
                 orcidOauth.authorizeUrl,
               ).href,