Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YamlDotNet dependency #30

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

joergrosenkranz
Copy link
Contributor

YamlDotNet.Signed was deprecated. That's why it was replaced by the current version of YamlDotNet. This fixes #29.

YamlDotNet.Signed was deprecated. That's why it was replaced by the current
version of YamlDotNet. This fixes PMudra#29.
@Roel84
Copy link
Collaborator

Roel84 commented Jan 9, 2025

The AppVeyor build is failing. Please have a look.

Are the remarks from @bh-sijtnic still applicable? The new YamlDotNet package does support NetStandard2.0 and is strong-named.

@joergrosenkranz
Copy link
Contributor Author

joergrosenkranz commented Jan 9, 2025

The AppVeyor build is failing. Please have a look.

Yes, exactly. That was my comment in the issue about: "I can build the assemblies and run the tests, but someone should have a look at the build files in the repo."
I have no idea how to fix the Fake build files.

The other comments are about moving the project forward to a new version. My fix is only for the deprecated dependency.

@Roel84
Copy link
Collaborator

Roel84 commented Jan 10, 2025

The AppVeyor build is failing. Please have a look.

Yes, exactly. That was my comment in the issue about: "I can build the assemblies and run the tests, but someone should have a look at the build files in the repo." I have no idea how to fix the Fake build files.

The other comments are about moving the project forward to a new version. My fix is only for the deprecated dependency.

I fixed the build script. If you update your branch it should build now.

@joergrosenkranz
Copy link
Contributor Author

Thanks, it seems to build now.

@Roel84
Copy link
Collaborator

Roel84 commented Jan 13, 2025

Changes looks good. Thank you for your contribution to the project.

I will publish a new NuGet package.

@Roel84 Roel84 merged commit 70ea2a6 into PMudra:master Jan 13, 2025
1 check passed
@Roel84
Copy link
Collaborator

Roel84 commented Jan 14, 2025

@joergrosenkranz unfortunately the API key for publishing the NuGet package is expired.

@PMudra could you renew the API key please?

@PMudra
Copy link
Owner

PMudra commented Jan 14, 2025

I have updated the key (which will be valid for a year) and triggered the NuGet publish process again. So the package should be available very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApiCheck depends on deprecated YamlDotNet.Signed package
3 participants