Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApiCheck depends on deprecated YamlDotNet.Signed package #29

Open
bh-sijtnic opened this issue Jul 10, 2024 · 3 comments · May be fixed by #30
Open

ApiCheck depends on deprecated YamlDotNet.Signed package #29

bh-sijtnic opened this issue Jul 10, 2024 · 3 comments · May be fixed by #30

Comments

@bh-sijtnic
Copy link

Hi @PMudra

When using the latest ApiCheck package in our environment, we run into the issue that it depends on the YamlDotNet.Signed NuGet package, while we depend on the (newer) YamlDotNet NuGet package.

As YamlDotNet.Signed is deprecated, we would recommend to remove this dependency and migrate to YamlDotNet.
StrongNameSigning of ApiCheck is then most likely no longer possible.

Our proposal would be to migrate ApiCheck from NetStandard2.0 to Net6.0, allowing us to use YamlDotNet and remove StrongNameSigning.
This will however remove support for the .NET Framework projects.
We could do this as part of a major version upgrade of the ApiCheck version (3.0.x).
Users who continue to need to support their .NET Framework projects can continue to use the 2.0.x packages
Starting 3.0 we would then only support .NET6.0 and higher.

We are happy to create a PR for this if you agree.

Looking forward to hear your thoughts.
@PMudra
Copy link
Owner

PMudra commented Jul 26, 2024

Hi @nico-1987, sounds good to me. Basically this is the next step after #26, right?

I feel I am not of much help to this project anymore. @Roel84 already has all the rights to review and merge pull requests. Please let me know if you need anything. You do not need my permission to make extensions to this project.

@bh-sijtnic
Copy link
Author

bh-sijtnic commented Aug 5, 2024 •
edited
Loading

Thanks @PMudra, we will have a closer look.
Roel is no longer part of our team, though we will post the PR and will see who can review.

joergrosenkranz added a commit to joergrosenkranz/ApiCheck that referenced this issue Jan 8, 2025
@joergrosenkranz
Update YamlDotNet dependency
8ffd525 
YamlDotNet.Signed was deprecated. That's why it was replaced by the current
version of YamlDotNet. This fixes PMudra#29.
@joergrosenkranz joergrosenkranz linked a pull request Jan 8, 2025 that will close this issue
Open
@joergrosenkranz
Copy link

I've added a PR that adresses this issue. I can build the assemblies and run the tests, but someone should have a look at the build files in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update YamlDotNet dependency joergrosenkranz/ApiCheck
3 participants
@PMudra @joergrosenkranz @bh-sijtnic