Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes of x86_64 compiler #31

Open
wants to merge 9 commits into
base: 1.30
Choose a base branch
from
Open

Fixes of x86_64 compiler #31

wants to merge 9 commits into from

Conversation

e2e4b6b7
Copy link
Contributor

  • Added name for dune-project (otherwise installation fails)
  • Fixed missed escaping for \r
  • Prohibited indirect assignment (if ... then a else b fi := 0) as:
    • It does not work correctly in terms of STI / STA and leads to invalid stack
    • For X86_64 it requires propagation of the assignment as variable may be stored in register
  • Added error if assembly toolchain failed (before this compiler returned with 0 code)
  • Some minor fixes of correctness

@Kakadu
Copy link
Collaborator

Kakadu commented Dec 30, 2024

@e2e4b6b7
Could you fix CI?

@e2e4b6b7
Copy link
Contributor Author

e2e4b6b7 commented Jan 5, 2025

Now CI fails in the same way as on the original branch. (There was a branch synchronization issue)

Additionally, I fixed #30 by -Wa,--noexecstack argument. But not removed any dirty hacks and not updated tests output as gen.ml is not working for me (it results with files with empty output)

@Kakadu Kakadu requested a review from danyaberezun January 5, 2025 12:08
@Kakadu
Copy link
Collaborator

Kakadu commented Jan 5, 2025

Now CI fails in the same way as on the original branch.

It looks like it started giving an exit code 1. It's scary

image

@e2e4b6b7
Copy link
Contributor Author

e2e4b6b7 commented Jan 5, 2025

It looks like it started giving an exit code 1. It's scary

Yes, but master branch doing the same right now

@Kakadu
Copy link
Collaborator

Kakadu commented Jan 5, 2025

Could you check that removing redirection and grep helps?

@e2e4b6b7
Copy link
Contributor Author

e2e4b6b7 commented Jan 5, 2025

Yes, looks like it is indeed issue of grep

image

I was failing because leftover grep command that
filters out a warning about '.note.GNU-stack'
(No idea where it was fixed)

Signed-off-by: Kakadu <[email protected]>
@Kakadu
Copy link
Collaborator

Kakadu commented Jan 9, 2025

It's better now, but it transformed into a Mac issue

@e2e4b6b7
Copy link
Contributor Author

e2e4b6b7 commented Jan 9, 2025

Also the same issue as on the master. Looks like it tries to build 32-bit runtime on macos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants