Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension for selection and storage of profile points #104

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cxcandid
Copy link

@cxcandid cxcandid commented Mar 1, 2025

This PR contains a small extension for the selection and storage of profile points in a “profile_points” layer.

Copy link
Collaborator

@nicogodet nicogodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the feature deactivable and disable by default ?

User could also choose an existing layer instead of a new memory layer. What do you think ?

Nevertheless good feature!

@cxcandid
Copy link
Author

cxcandid commented Mar 3, 2025

@nicogodet do we really need to make this feature deactivable? ...there is no other function that would be in conflict here.

@nicogodet
Copy link
Collaborator

@nicogodet do we really need to make this feature deactivable? ...there is no other function that would be in conflict here.

People can miss click on Canvas and create an unwanted layer.

@cxcandid
Copy link
Author

cxcandid commented Mar 4, 2025

Added a checkbox for activating/deactivating point storage.

@cxcandid cxcandid requested a review from nicogodet March 5, 2025 16:15
@nicogodet
Copy link
Collaborator

Could you rebase and update plugin version ?

Could you provide user a feedback that point has been added to profile_points layer using self.iface.mainWindow().statusBar().showMessage("your_message") ?

The "Options" group box is getting more and more crowded and I don't like that, it reduces the layer tree above. I might move most of checkboxes to Settings tab in full resolution groupbox (and rename this groupbox). If you are motivated, you can do this moves. Otherwise I will do it but it might delayed the release of new version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants